git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/8] t7900: remove register dependency

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
Oct 14, 2023, 21:45 UTC
Message-ID
<6d9398e64d0acb69219877c54ba3fdfa0faa0dbf.1697319294.git.code@khaugsbakk.name>
In-Reply-To
<cover.1697319294.git.code@khaugsbakk.name>

`stop from existing schedule` depends on the preceding test `start from empty cron table` because the preceding test registers the repository. Without it, the “stop” test fails because `config` fails to get the repository:

    git config --get --global --fixed-value maintenance.repo "$(pwd)"

Remove this dependency by setting up the state and tearing it down independently.

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
 t/t7900-maintenance.sh | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
index 487e326b3fa..ca86b2ba687 100755
--- a/t/t7900-maintenance.sh
+++ b/t/t7900-maintenance.sh
@@ -588,6 +588,7 @@ test_expect_success 'start --scheduler=<scheduler>' '
 '
 
 test_expect_success 'start from empty cron table' '
+	test_when_finished git maintenance unregister &&
 	GIT_TEST_MAINT_SCHEDULER="crontab:test-tool crontab cron.txt" git maintenance start --scheduler=crontab &&
 
 	# start registers the repo
@@ -599,6 +600,8 @@ test_expect_success 'start from empty cron table' '
 '
 
 test_expect_success 'stop from existing schedule' '
+	test_when_finished git maintenance unregister &&
+	git maintenance register &&
 	GIT_TEST_MAINT_SCHEDULER="crontab:test-tool crontab cron.txt" git maintenance stop &&
 
 	# stop does not unregister the repo
-- 
2.42.0.2.g879ad04204
Previous: Kristoffer HaugsbakkNext: Kristoffer Haugsbakk
Message 2 of 16 in “t7900: untangle test dependencies”
  1. 0/8 t7900: untangle test dependenciesKristoffer Haugsbakk, Oct 14, 2023
  2. 1/8 t7900: remove register dependencyKristoffer Haugsbakk, Oct 14, 2023
  3. 2/8 t7900: setup and tear down clonesKristoffer Haugsbakk, Oct 14, 2023
  4. Junio C HamanoOct 17, 2023
  5. Kristoffer HaugsbakkOct 17, 2023
  6. 3/8 t7900: create commit so that branch is bornKristoffer Haugsbakk, Oct 14, 2023
  7. 4/8 t7900: factor out inheritance test dependencyKristoffer Haugsbakk, Oct 14, 2023
  8. 5/8 t7900: factor out common schedule setupKristoffer Haugsbakk, Oct 14, 2023
  9. 6/8 t7900: fix `pfx` dependencyKristoffer Haugsbakk, Oct 14, 2023
  10. 7/8 t7900: fix `print-args` dependencyKristoffer Haugsbakk, Oct 14, 2023
  11. 8/8 t7900: factor out packfile dependencyKristoffer Haugsbakk, Oct 14, 2023
  12. 9/8 t7900: fix register dependencyKristoffer Haugsbakk, Oct 14, 2023
  13. Jeff KingOct 15, 2023
  14. Junio C HamanoOct 17, 2023
  15. Kristoffer HaugsbakkOct 17, 2023
  16. Junio C HamanoOct 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.