git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] send-email: make it easy to discern the messages for each patch

From
DSDragan Simic <dsimic@manjaro.org>
Date
Apr 6, 2024, 17:08 UTC
Message-ID
<6cd48321180195e7070825dbc3f49578@manjaro.org>
In-Reply-To
<xmqq5xwul8vn.fsf@gitster.g>
On 2024-04-06 19:05, Junio C Hamano wrote:
Show 12 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> The whole thing deserves to be a three-patch series, the first one
>> being a preliminarly "let's move the final newline out of the
>> translatable string" step, followed by "let's have a gap between
>> output for each patch sent out".  Perhaps another "even during
>> sending a single patch, we may want extra blank lines when use of
>> editor and other user interation is involved" patch on top.
> 
> Or the latter two could be done in a single patch.  I'll have to
> re-review the thing (if I were the only reviewer of the topic) so
> doing so would delay the completion of the topic, though.

Huh, I've already separated this patch into three patches, and IMHO they look nice and make everything less error prone. Would you agree with the three-patch approach, please?

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 8 in “send-email: make it easy to discern the messages for each patch”
  1. send-email: make it easy to discern the messages for each patchDragan Simic, Apr 6, 2024
  2. Junio C HamanoApr 6, 2024
  3. Dragan SimicApr 6, 2024
  4. Dragan SimicApr 6, 2024
  5. Junio C HamanoApr 6, 2024
  6. Dragan SimicApr 6, 2024
  7. Junio C HamanoApr 8, 2024
  8. Dragan SimicApr 8, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.