git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 03/16] sequencer: remove the 'arg' field from todo_item

From
PWPhillip Wood <phillip.wood@talktalk.net>
Date
Jan 21, 2019, 14:59 UTC
Message-ID
<6bc7f154-a18a-3311-cbd0-c2a578931c4b@talktalk.net>
In-Reply-To
<20181229160413.19333-4-alban.gruin@gmail.com>
Hi Alban

I think this is a good change, I just wonder if it would be better to have an accessor function to get the arg pointer from a todo list item see below

On 29/12/2018 16:04, Alban Gruin wrote:
Show 198 quoted lines
> The 'arg' field of todo_item used to store the address of the first byte
> of the parameter of a command in a todo list.  It was associated with
> the length of the parameter (the 'arg_len' field).
> 
> This replaces the 'arg' field by 'arg_offset'.  This new field does not
> store the address of the parameter, but the position of the first
> character of the parameter in the buffer.
> 
> This will prevent todo_list_add_exec_commands() from having to do awful
> pointer arithmetics when growing the todo list buffer.
> 
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
> ---
> This is a new commit.
> 
>   sequencer.c | 61 ++++++++++++++++++++++++++++-------------------------
>   sequencer.h |  4 ++--
>   2 files changed, 34 insertions(+), 31 deletions(-)
> 
> diff --git a/sequencer.c b/sequencer.c
> index 5b84a20532..61be04ccc5 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -1950,7 +1950,7 @@ static struct todo_item *append_new_todo(struct todo_list *todo_list)
>   }
>   
>   static int parse_insn_line(struct repository *r, struct todo_item *item,
> -			   const char *bol, char *eol)
> +			   const char *buf, const char *bol, char *eol)
>   {
>   	struct object_id commit_oid;
>   	char *end_of_object_name;
> @@ -1964,7 +1964,7 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
>   	if (bol == eol || *bol == '\r' || *bol == comment_line_char) {
>   		item->command = TODO_COMMENT;
>   		item->commit = NULL;
> -		item->arg = bol;
> +		item->arg_offset = bol - buf;
>   		item->arg_len = eol - bol;
>   		return 0;
>   	}
> @@ -1991,7 +1991,7 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
>   			return error(_("%s does not accept arguments: '%s'"),
>   				     command_to_string(item->command), bol);
>   		item->commit = NULL;
> -		item->arg = bol;
> +		item->arg_offset = bol - buf;
>   		item->arg_len = eol - bol;
>   		return 0;
>   	}
> @@ -2003,7 +2003,7 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
>   	if (item->command == TODO_EXEC || item->command == TODO_LABEL ||
>   	    item->command == TODO_RESET) {
>   		item->commit = NULL;
> -		item->arg = bol;
> +		item->arg_offset = bol - buf;
>   		item->arg_len = (int)(eol - bol);
>   		return 0;
>   	}
> @@ -2017,7 +2017,7 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
>   		} else {
>   			item->flags |= TODO_EDIT_MERGE_MSG;
>   			item->commit = NULL;
> -			item->arg = bol;
> +			item->arg_offset = bol - buf;
>   			item->arg_len = (int)(eol - bol);
>   			return 0;
>   		}
> @@ -2029,8 +2029,9 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
>   	status = get_oid(bol, &commit_oid);
>   	*end_of_object_name = saved;
>   
> -	item->arg = end_of_object_name + strspn(end_of_object_name, " \t");
> -	item->arg_len = (int)(eol - item->arg);
> +	bol = end_of_object_name + strspn(end_of_object_name, " \t");
> +	item->arg_offset = bol - buf;
> +	item->arg_len = (int)(eol - bol);
>   
>   	if (status < 0)
>   		return -1;
> @@ -2058,11 +2059,11 @@ int todo_list_parse_insn_buffer(struct repository *r, char *buf,
>   
>   		item = append_new_todo(todo_list);
>   		item->offset_in_buf = p - todo_list->buf.buf;
> -		if (parse_insn_line(r, item, p, eol)) {
> +		if (parse_insn_line(r, item, buf, p, eol)) {
>   			res = error(_("invalid line %d: %.*s"),
>   				i, (int)(eol - p), p);
>   			item->command = TODO_COMMENT + 1;
> -			item->arg = p;
> +			item->arg_offset = p - buf;
>   			item->arg_len = (int)(eol - p);
>   			item->commit = NULL;
>   		}
> @@ -2402,7 +2403,7 @@ static int walk_revs_populate_todo(struct todo_list *todo_list,
>   
>   		item->command = command;
>   		item->commit = commit;
> -		item->arg = NULL;
> +		item->arg_offset = 0;
>   		item->arg_len = 0;
>   		item->offset_in_buf = todo_list->buf.len;
>   		subject_len = find_commit_subject(commit_buffer, &subject);
> @@ -3438,6 +3439,8 @@ static int pick_commits(struct repository *r,
>   
>   	while (todo_list->current < todo_list->nr) {
>   		struct todo_item *item = todo_list->items + todo_list->current;
> +		const char *arg = todo_list->buf.buf + item->arg_offset;
> +
>   		if (save_todo(todo_list, opts))
>   			return -1;
>   		if (is_rebase_i(opts)) {
> @@ -3488,10 +3491,9 @@ static int pick_commits(struct repository *r,
>   					fprintf(stderr,
>   						_("Stopped at %s...  %.*s\n"),
>   						short_commit_name(commit),
> -						item->arg_len, item->arg);
> +						item->arg_len, arg);
>   				return error_with_patch(r, commit,
> -					item->arg, item->arg_len, opts, res,
> -					!res);
> +					arg, item->arg_len, opts, res, !res);
>   			}
>   			if (is_rebase_i(opts) && !res)
>   				record_in_rewritten(&item->commit->object.oid,
> @@ -3500,7 +3502,7 @@ static int pick_commits(struct repository *r,
>   				if (res == 1)
>   					intend_to_amend();
>   				return error_failed_squash(r, item->commit, opts,
> -					item->arg_len, item->arg);
> +					item->arg_len, arg);
>   			} else if (res && is_rebase_i(opts) && item->commit) {
>   				int to_amend = 0;
>   				struct object_id oid;
> @@ -3519,16 +3521,16 @@ static int pick_commits(struct repository *r,
>   					to_amend = 1;
>   
>   				return res | error_with_patch(r, item->commit,
> -						item->arg, item->arg_len, opts,
> +						arg, item->arg_len, opts,
>   						res, to_amend);
>   			}
>   		} else if (item->command == TODO_EXEC) {
> -			char *end_of_arg = (char *)(item->arg + item->arg_len);
> +			char *end_of_arg = (char *)(arg + item->arg_len);
>   			int saved = *end_of_arg;
>   			struct stat st;
>   
>   			*end_of_arg = '\0';
> -			res = do_exec(r, item->arg);
> +			res = do_exec(r, arg);
>   			*end_of_arg = saved;
>   
>   			/* Reread the todo file if it has changed. */
> @@ -3545,14 +3547,14 @@ static int pick_commits(struct repository *r,
>   				todo_list->current = -1;
>   			}
>   		} else if (item->command == TODO_LABEL) {
> -			if ((res = do_label(r, item->arg, item->arg_len)))
> +			if ((res = do_label(r, arg, item->arg_len)))
>   				reschedule = 1;
>   		} else if (item->command == TODO_RESET) {
> -			if ((res = do_reset(r, item->arg, item->arg_len, opts)))
> +			if ((res = do_reset(r, arg, item->arg_len, opts)))
>   				reschedule = 1;
>   		} else if (item->command == TODO_MERGE) {
>   			if ((res = do_merge(r, item->commit,
> -					    item->arg, item->arg_len,
> +					    arg, item->arg_len,
>   					    item->flags, opts)) < 0)
>   				reschedule = 1;
>   			else if (item->commit)
> @@ -3561,9 +3563,8 @@ static int pick_commits(struct repository *r,
>   			if (res > 0)
>   				/* failed with merge conflicts */
>   				return error_with_patch(r, item->commit,
> -							item->arg,
> -							item->arg_len, opts,
> -							res, 0);
> +							arg, item->arg_len,
> +							opts, res, 0);
>   		} else if (!is_noop(item->command))
>   			return error(_("unknown command %d"), item->command);
>   
> @@ -3578,9 +3579,8 @@ static int pick_commits(struct repository *r,
>   			if (item->commit)
>   				return error_with_patch(r,
>   							item->commit,
> -							item->arg,
> -							item->arg_len, opts,
> -							res, 0);
> +							arg, item->arg_len,
> +							opts, res, 0);
>   		}
>   
>   		todo_list->current++;
> @@ -4520,7 +4520,8 @@ int transform_todos(struct repository *r, unsigned flags)
>   	for (item = todo_list.items, i = 0; i < todo_list.nr; i++, item++) {

I think the changes to this function would be clearer with + const char *arg = todo_list.buf.buf + item->arg_offset here and then used arg instead of item->arg rather than calculating arg twice. Given that we are going to need to calculate arg again in check_todo_list() maybe it would be better to have a function

const char *get_item_arg(struct todo_list *todo, struct todo_list_item 
*item) {
	return todo->buf.buf + item->arg_offset;
}

and do + const char *arg = get_item_arg(&todo_list, item); to avoid any accidents when calculating arg in future.

Best Wishes
Phillip
Show 45 quoted lines
>   		/* if the item is not a command write it and continue */
>   		if (item->command >= TODO_COMMENT) {
> -			strbuf_addf(&buf, "%.*s\n", item->arg_len, item->arg);
> +			strbuf_addf(&buf, "%.*s\n", item->arg_len,
> +				    todo_list.buf.buf + item->arg_offset);
>   			continue;
>   		}
>   
> @@ -4550,7 +4551,8 @@ int transform_todos(struct repository *r, unsigned flags)
>   		if (!item->arg_len)
>   			strbuf_addch(&buf, '\n');
>   		else
> -			strbuf_addf(&buf, " %.*s\n", item->arg_len, item->arg);
> +			strbuf_addf(&buf, " %.*s\n", item->arg_len,
> +				    todo_list.buf.buf + item->arg_offset);
>   	}
>   
>   	i = write_message(buf.buf, buf.len, todo_file, 0);
> @@ -4626,7 +4628,8 @@ int check_todo_list(struct repository *r)
>   		if (commit && !*commit_seen_at(&commit_seen, commit)) {
>   			strbuf_addf(&missing, " - %s %.*s\n",
>   				    short_commit_name(commit),
> -				    item->arg_len, item->arg);
> +				    item->arg_len,
> +				    todo_list.buf.buf + item->arg_offset);
>   			*commit_seen_at(&commit_seen, commit) = 1;
>   		}
>   	}
> diff --git a/sequencer.h b/sequencer.h
> index 7dc4d8946b..70a896e756 100644
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -104,9 +104,9 @@ struct todo_item {
>   	enum todo_command command;
>   	struct commit *commit;
>   	unsigned int flags;
> -	const char *arg;
>   	int arg_len;
> -	size_t offset_in_buf;
> +	/* The offset of the command and its argument in the strbuf */
> +	size_t offset_in_buf, arg_offset;
>   };
>   
>   struct todo_list {
>
Previous: Alban GruinNext: Johannes Schindelin
Message 81 of 190 in “sequencer: refactor functions working on a todo_list”
  1. 00/15 sequencer: refactor functions working on a todo_listAlban Gruin, Oct 7, 2018
  2. 02/15 sequencer: make the todo_list structure publicAlban Gruin, Oct 7, 2018
  3. 01/15 sequencer: clear the number of items of a todo_list before parsingAlban Gruin, Oct 7, 2018
  4. 03/15 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Oct 7, 2018
  5. Phillip WoodOct 11, 2018
  6. 04/15 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Oct 7, 2018
  7. Phillip WoodOct 11, 2018
  8. Alban GruinOct 11, 2018
  9. Phillip WoodOct 12, 2018
  10. Alban GruinOct 12, 2018
  11. 08/15 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Oct 7, 2018
  12. Phillip WoodOct 11, 2018
  13. Alban GruinOct 11, 2018
  14. 10/15 rebase-interactive: use todo_list_transform() in edit_todo_list()Alban Gruin, Oct 7, 2018
  15. Phillip WoodOct 11, 2018
  16. Alban GruinOct 11, 2018
  17. 11/15 rebase-interactive: append_todo_help() changesAlban Gruin, Oct 7, 2018
  18. 12/15 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Oct 7, 2018
  19. 13/15 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Oct 7, 2018
  20. 14/15 sequencer: fix a call to error() in transform_todo_file()Alban Gruin, Oct 7, 2018
  21. 15/15 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Oct 7, 2018
  22. 07/15 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Oct 7, 2018
  23. SZEDER GáborOct 12, 2018
  24. Junio C HamanoOct 19, 2018
  25. SZEDER GáborOct 19, 2018
  26. 09/15 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Oct 7, 2018
  27. 06/15 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Oct 7, 2018
  28. 05/15 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Oct 7, 2018
  29. Alban GruinOct 7, 2018
  30. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Oct 27, 2018
  31. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Oct 27, 2018
  32. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Oct 27, 2018
  33. 03/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Oct 27, 2018
  34. 04/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Oct 27, 2018
  35. Phillip WoodOct 30, 2018
  36. Alban GruinNov 1, 2018
  37. 05/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Oct 27, 2018
  38. 06/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Oct 27, 2018
  39. Phillip WoodOct 30, 2018
  40. Alban GruinNov 1, 2018
  41. Phillip WoodNov 2, 2018
  42. Alban GruinNov 2, 2018
  43. Phillip WoodNov 2, 2018
  44. 07/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Oct 27, 2018
  45. 08/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Oct 27, 2018
  46. 09/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Oct 27, 2018
  47. 10/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Oct 27, 2018
  48. 11/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Oct 27, 2018
  49. 12/16 rebase-interactive: append_todo_help() changesAlban Gruin, Oct 27, 2018
  50. 13/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Oct 27, 2018
  51. 15/16 sequencer: fix a call to error() in transform_todo_file()Alban Gruin, Oct 27, 2018
  52. 14/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Oct 27, 2018
  53. 16/16 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Oct 27, 2018
  54. Junio C HamanoOct 29, 2018
  55. Alban GruinOct 29, 2018
  56. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Nov 9, 2018
  57. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Nov 9, 2018
  58. 03/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Nov 9, 2018
  59. 04/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Nov 9, 2018
  60. 05/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Nov 9, 2018
  61. 06/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Nov 9, 2018
  62. Phillip WoodNov 30, 2018
  63. Johannes SchindelinNov 30, 2018
  64. Phillip WoodDec 10, 2018
  65. Alban GruinDec 28, 2018
  66. 07/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Nov 9, 2018
  67. 08/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Nov 9, 2018
  68. 09/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Nov 9, 2018
  69. 12/16 rebase-interactive: append_todo_help() changesAlban Gruin, Nov 9, 2018
  70. 11/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Nov 9, 2018
  71. 14/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Nov 9, 2018
  72. 13/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Nov 9, 2018
  73. 15/16 sequencer: fix a call to error() in transform_todo_file()Alban Gruin, Nov 9, 2018
  74. 16/16 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Nov 9, 2018
  75. 10/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Nov 9, 2018
  76. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Nov 9, 2018
  77. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Dec 29, 2018
  78. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Dec 29, 2018
  79. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Dec 29, 2018
  80. 03/16 sequencer: remove the 'arg' field from todo_itemAlban Gruin, Dec 29, 2018
  81. Phillip WoodJan 21, 2019
  82. Johannes SchindelinJan 22, 2019
  83. 04/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Dec 29, 2018
  84. 05/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Dec 29, 2018
  85. 07/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Dec 29, 2018
  86. 08/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Dec 29, 2018
  87. 09/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Dec 29, 2018
  88. 10/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Dec 29, 2018
  89. 12/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Dec 29, 2018
  90. 11/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Dec 29, 2018
  91. 06/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Dec 29, 2018
  92. 13/16 rebase-interactive: append_todo_help() changesAlban Gruin, Dec 29, 2018
  93. 16/16 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Dec 29, 2018
  94. 14/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Dec 29, 2018
  95. 15/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Dec 29, 2018
  96. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Jan 23, 2019
  97. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Jan 23, 2019
  98. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Jan 23, 2019
  99. 03/16 sequencer: remove the 'arg' field from todo_itemAlban Gruin, Jan 23, 2019
  100. 04/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Jan 23, 2019
  101. 05/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Jan 23, 2019
  102. 06/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Jan 23, 2019
  103. 07/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Jan 23, 2019
  104. 08/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Jan 23, 2019
  105. 10/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Jan 23, 2019
  106. 11/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Jan 23, 2019
  107. 09/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Jan 23, 2019
  108. 13/16 rebase-interactive: append_todo_help() changesAlban Gruin, Jan 23, 2019
  109. 14/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Jan 23, 2019
  110. 15/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Jan 23, 2019
  111. 16/16 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Jan 23, 2019
  112. 12/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Jan 23, 2019
  113. Junio C HamanoJan 24, 2019
  114. Alban GruinJan 24, 2019
  115. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Jan 29, 2019
  116. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Jan 29, 2019
  117. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Jan 29, 2019
  118. 03/16 sequencer: remove the 'arg' field from todo_itemAlban Gruin, Jan 29, 2019
  119. 04/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Jan 29, 2019
  120. 05/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Jan 29, 2019
  121. 07/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Jan 29, 2019
  122. Phillip WoodJan 31, 2019
  123. Alban GruinJan 31, 2019
  124. Phillip WoodJan 31, 2019
  125. Phillip WoodFeb 1, 2019
  126. Alban GruinFeb 2, 2019
  127. Phillip WoodFeb 7, 2019
  128. 08/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Jan 29, 2019
  129. 11/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Jan 29, 2019
  130. Phillip WoodFeb 7, 2019
  131. 10/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Jan 29, 2019
  132. Junio C HamanoJan 29, 2019
  133. Alban GruinJan 29, 2019
  134. Junio C HamanoJan 29, 2019
  135. 13/16 rebase-interactive: append_todo_help() changesAlban Gruin, Jan 29, 2019
  136. 09/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Jan 29, 2019
  137. 12/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Jan 29, 2019
  138. 16/16 rebase--interactive: move transform_todo_file() to rebase--interactive.cAlban Gruin, Jan 29, 2019
  139. Phillip WoodFeb 1, 2019
  140. Alban GruinFeb 2, 2019
  141. 15/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Jan 29, 2019
  142. 14/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Jan 29, 2019
  143. Phillip WoodFeb 1, 2019
  144. Alban GruinFeb 2, 2019
  145. Alban GruinFeb 6, 2019
  146. Phillip WoodFeb 8, 2019
  147. 06/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Jan 29, 2019
  148. 00/16 sequencer: refactor functions working on a todo_listAlban Gruin, Feb 10, 2019
  149. 01/16 sequencer: changes in parse_insn_buffer()Alban Gruin, Feb 10, 2019
  150. 03/16 sequencer: remove the 'arg' field from todo_itemAlban Gruin, Feb 10, 2019
  151. 02/16 sequencer: make the todo_list structure publicAlban Gruin, Feb 10, 2019
  152. 04/16 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Feb 10, 2019
  153. 06/16 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Feb 10, 2019
  154. 05/16 sequencer: introduce todo_list_write_to_file()Alban Gruin, Feb 10, 2019
  155. 07/16 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Feb 10, 2019
  156. Phillip WoodFeb 12, 2019
  157. Alban GruinFeb 12, 2019
  158. Phillip WoodFeb 13, 2019
  159. 12/16 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Feb 10, 2019
  160. 10/16 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Feb 10, 2019
  161. 08/16 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Feb 10, 2019
  162. 13/16 rebase-interactive: append_todo_help() changesAlban Gruin, Feb 10, 2019
  163. 11/16 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Feb 10, 2019
  164. Phillip WoodFeb 13, 2019
  165. 14/16 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Feb 10, 2019
  166. Phillip WoodFeb 13, 2019
  167. 09/16 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Feb 10, 2019
  168. 16/16 rebase--interactive: move several functions to rebase--interactive.cAlban Gruin, Feb 10, 2019
  169. Phillip WoodFeb 13, 2019
  170. 15/16 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Feb 10, 2019
  171. 00/18 sequencer: refactor functions working on a todo_listAlban Gruin, Mar 5, 2019
  172. 01/18 sequencer: changes in parse_insn_buffer()Alban Gruin, Mar 5, 2019
  173. 02/18 sequencer: make the todo_list structure publicAlban Gruin, Mar 5, 2019
  174. 03/18 sequencer: remove the 'arg' field from todo_itemAlban Gruin, Mar 5, 2019
  175. 04/18 sequencer: refactor transform_todos() to work on a todo_listAlban Gruin, Mar 5, 2019
  176. 05/18 sequencer: introduce todo_list_write_to_file()Alban Gruin, Mar 5, 2019
  177. 06/18 sequencer: refactor check_todo_list() to work on a todo_listAlban Gruin, Mar 5, 2019
  178. 07/18 sequencer: refactor sequencer_add_exec_commands() to work on a todo_listAlban Gruin, Mar 5, 2019
  179. 08/18 sequencer: refactor rearrange_squash() to work on a todo_listAlban Gruin, Mar 5, 2019
  180. 09/18 sequencer: make sequencer_make_script() write its script to a strbufAlban Gruin, Mar 5, 2019
  181. 10/18 sequencer: change complete_action() to use the refactored functionsAlban Gruin, Mar 5, 2019
  182. 11/18 rebase--interactive: move sequencer_add_exec_commands()Alban Gruin, Mar 5, 2019
  183. 12/18 rebase--interactive: move rearrange_squash_in_todo_file()Alban Gruin, Mar 5, 2019
  184. 13/18 sequencer: refactor skip_unnecessary_picks() to work on a todo_listAlban Gruin, Mar 5, 2019
  185. 14/18 rebase-interactive: use todo_list_write_to_file() in edit_todo_list()Alban Gruin, Mar 5, 2019
  186. 15/18 rebase-interactive: append_todo_help() changesAlban Gruin, Mar 5, 2019
  187. 16/18 rebase-interactive: rewrite edit_todo_list() to handle the initial editAlban Gruin, Mar 5, 2019
  188. 17/18 sequencer: use edit_todo_list() in complete_action()Alban Gruin, Mar 5, 2019
  189. 18/18 rebase--interactive: move transform_todo_file()Alban Gruin, Mar 5, 2019
  190. Phillip WoodMar 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.