git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] blame.c: replace instance of !oidcmp for oideq

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 9, 2020, 12:39 UTC
Message-ID
<6b84f112-7e3f-3a78-3766-033fcf494464@gmail.com>
In-Reply-To
<20200908211053.807194-1-eantoranz@gmail.com>
On 9/8/2020 5:10 PM, Edmundo Carmona Antoranz wrote:
> 0906ac2b54b introduced a call to oidcmp() that should be
> replaced by oideq() (the latter introduced in 14438c4).

Short-OIDs on their own are not enough. Please use the format "abbreviated hash (subject, date)" as mentioned in my earlier reply:

0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
14438c4 (introduce hasheq() and oideq(), 2018-08-28)

See Documentation/SubmittingPatches [1] for more information on this.

[1] https://github.com/git/git/blob/3a238e539bcdfe3f9eb5010fd218640c1b499f7a/Documentation/SubmittingPatches#L144-L165

Thanks, -Stolee

Previous: Edmundo Carmona AntoranzNext: Edmundo Carmona Antoranz
Message 2 of 6 in “blame.c: replace instance of !oidcmp for oideq”
  1. blame.c: replace instance of !oidcmp for oideqEdmundo Carmona Antoranz, Sep 8, 2020
  2. Derrick StoleeSep 9, 2020
  3. Edmundo Carmona AntoranzSep 9, 2020
  4. Junio C HamanoSep 9, 2020
  5. Edmundo Carmona AntoranzSep 9, 2020
  6. Junio C HamanoSep 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.