[PATCH 10/21] remote: make match_refs() not short-circuit
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Feb 25, 2009, 08:32 UTC
- Message-ID
- <6a24ea1542d8a1ec750005a710f40e0730db1aa4.1235546708.git.jaysoffian@gmail.com>
- In-Reply-To
- <cover.1235546707.git.jaysoffian@gmail.com>
match_refs() returns non-zero if there is an error in match_explicit_refs(), without handling any remaining pattern ref specs.
Its existing callers exit upon receiving non-zero, so a partial result is of no consequence to them; however a new caller, builtin-remote, is interested in the complete result even if there are errors in match_explicit_refs().
Signed-off-by: Jay Soffian <jaysoffian@gmail.com> --- remote.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/remote.c b/remote.c index 81def8b..926f842 100644 --- a/remote.c +++ b/remote.c @@ -1044,6 +1044,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail, struct refspec *rs; int send_all = flags & MATCH_REFS_ALL; int send_mirror = flags & MATCH_REFS_MIRROR; + int errs; static const char *default_refspec[] = { ":", 0 }; if (!nr_refspec) { @@ -1051,8 +1052,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail, refspec = default_refspec; } rs = parse_push_refspec(nr_refspec, (const char **) refspec); - if (match_explicit_refs(src, dst, dst_tail, rs, nr_refspec)) - return -1; + errs = match_explicit_refs(src, dst, dst_tail, rs, nr_refspec); /* pick the remainder */ for ( ; src; src = src->next) { @@ -1108,6 +1108,8 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail, free_name: free(dst_name); } + if (errs) + return -1; return 0; }
-- 1.6.2.rc1.291.g83eb