Re: [PATCH] git-svn: refuse to dcommit non-UTF-8 messages

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: May 29, 2009, 14:11 UTC
Message-ID: <6I7Qq-BKaJmSe6FJkYgjMpNqo6RFAVB0STpL09QJO1skOCB2ezM6mA@cipher.nrlssc.navy.mil>
In-Reply-To: <7v3aaoe40j.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 14 quoted lines

> Eric Wong <normalperson@yhbt.net> writes:
> 
>>  t/t9139-git-svn-non-utf8-commitencoding.sh |   47 ++++++++++++++++++++++++++++
> 
> Hmm.
> 
>> +# Copyright (c) 2009 Eric Wong
>> +
>> +test_description='git svn refuses to dcommit non-UTF8 messages'
>> +
>> +. ./lib-git-svn.sh
> 
> This passes when merged to 'master', but together with bc/old-iconv branch
> cooking in 'next' it breaks.

Yeah, it's the second for loop which accesses the files in t/t3900/. bc/old-iconv replaces each occurrence of ISO-8859-1 with ISO8859-1 and EUCJP with eucJP since old Solaris didn't know both names and modern platforms handle either name. The text files in t/t3900/ were renamed accordingly.

It would be nice to use these older names here too, even though I won't be able to test it since svn is not installed on the older platforms I have access to.

-brandon