Re: [PATCH] gitk: let you easily specify lines of context in diff view

From: Steffen Prohaska <prohaska@zib.de>
Date: Jul 27, 2007, 05:52 UTC
Message-ID: <6EA8D0EC-6E64-4F0E-BEDB-A8C5C91AAB53@zib.de>
In-Reply-To: <18088.38093.876993.410483@cargo.ozlabs.ibm.com>

On Jul 26, 2007, at 2:34 PM, Paul Mackerras wrote:

Show 10 quoted lines

> Steffen Prohaska writes:
>
>> More lines of context sometimes help to better understand a diff.
>> This patch introduces a text field above the box displaying the
>> blobdiffs. You can type in the number of lines of context that
>> you wish to view.
>
> Nice idea!  I suggest you use a spinbox instead of an entry though,
> since that has up and down buttons, and allows you to restrict the
> value to an integer.

Thanks. Will try that.

Show 5 quoted lines

>>    * I don't know how to update the view after entering a new value.
>
> You can put a trace on the associated variable and specify a function
> to be called when the variable's value changes.  Grep for "trace add
> variable" in gitk to see how it's done.

This is already included in the patch but I don't know which of gtk's procs to call to update the view. gitk would need to execute git diff and update the text box in the bottom left. I tried 'dodiffindex' but this causes corruptions of the history view.

	Steffen