Re: [PATCH 1/2] travis-ci: don't store P4 and Git LFS in the working tree

From: Lars Schneider <larsxschneider@gmail.com>
Date: Jan 2, 2018, 19:38 UTC
Message-ID: <6C09CC28-A94D-4731-96D7-E8637E248B4E@gmail.com>
In-Reply-To: <20171231160206.19481-2-szeder.dev@gmail.com>

Show 13 quoted lines

> On 31 Dec 2017, at 17:02, SZEDER Gábor <szeder.dev@gmail.com> wrote:
> 
> The Clang and GCC 64 bit Linux build jobs download and store the P4
> and Git LFS executables under the current directory, which is the
> working tree that we are about to build and test.  This means that Git
> commands like 'status' or 'ls-files' would list these files as
> untracked.  The next commit is about to make sure that there are no
> untracked files present after the build, and the downloaded
> executables in the working tree are interfering with those upcoming
> checks.
> 
> Therefore, let's download P4 and Git LFS in the home directory,
> outside of the working tree.

I was concerned for a moment that the executables would not be available to the 32-bit build anymore... but we don't use them in that build anyways.

Looks good to me!

- Lars

Show 24 quoted lines

> 
> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
> ---
> ci/lib-travisci.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh
> index bade71617..1543b7959 100755
> --- a/ci/lib-travisci.sh
> +++ b/ci/lib-travisci.sh
> @@ -99,8 +99,8 @@ linux-clang|linux-gcc)
> 	export LINUX_P4_VERSION="16.2"
> 	export LINUX_GIT_LFS_VERSION="1.5.2"
> 
> -	P4_PATH="$(pwd)/custom/p4"
> -	GIT_LFS_PATH="$(pwd)/custom/git-lfs"
> +	P4_PATH="$HOME/custom/p4"
> +	GIT_LFS_PATH="$HOME/custom/git-lfs"
> 	export PATH="$GIT_LFS_PATH:$P4_PATH:$PATH"
> 	;;
> osx-clang|osx-gcc)
> -- 
> 2.16.0.rc0.67.g3a46dbca7
>