Re: [PATCH] Doc: no midx and partial clone relation

From: Derrick Stolee <stolee@gmail.com>
Date: Nov 22, 2021, 19:29 UTC
Message-ID: <69e71cf4-ddab-4791-79e1-51ed990a0273@gmail.com>
In-Reply-To: <20211122184114.3328662-1-jonathantanmy@google.com>

On 11/22/2021 1:41 PM, Jonathan Tan wrote:

Show 11 quoted lines

> The multi-pack index treats promisor packfiles (that is, packfiles that
> have an accompanying .promisor file) the same as other packfiles. Remove
> a section in the documentation that seems to indicate otherwise.
> 
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> Stolee, can you check if my understanding is correct?
> 
> To my recollection, midx does not treat promisor packfiles specially,
> and searching for "promisor" in midx.c seems to support that (the only
> results are relating to selection of commits for midx bitmap creation).

Yes, you are correct that the promisor packfiles are included in the multi-pack-index.

Show 5 quoted lines

> -- The partial clone feature records special "promisor" packs that
> -  may point to objects that are not stored locally, but available
> -  on request to a server. The multi-pack-index does not currently
> -  track these promisor packs.
> -

The intention of this paragraph was probably that the multi-pack-index file does not track the properties of a pack-file such as whether a .promisor or .keep file exists. I think one thought was to eventually let the multi-pack-index track those properties, but there wasn't much value in it.

Deleting this paragraph is a suitable clarification.

Thanks, -Stolee