git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] cmake(install): fix double .exe suffixes

From
DGDennis Ameling via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 27, 2021, 23:06 UTC
Message-ID
<69856f278645ebe1a9779aaa0a6894db33e22b3a.1616886386.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.887.git.1616886386.gitgitgadget@gmail.com>
From: Dennis Ameling <dennis@dennisameling.com>

By mistake, the `.exe` extension is appended _twice_ when installing the dashed executables into `libexec/git-core/` on Windows (the extension is already appended when adding items to the `git_links` list in the `#Creating hardlinks` section).

Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 contrib/buildsystems/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
index 12c40a72bfff..da2811ae3aad 100644
--- a/contrib/buildsystems/CMakeLists.txt
+++ b/contrib/buildsystems/CMakeLists.txt
@@ -832,12 +832,12 @@ install(CODE "file(CREATE_LINK ${CMAKE_INSTALL_PREFIX}/bin/git-shell${EXE_EXTENS
 
 foreach(b ${git_links})
 	string(REPLACE "${CMAKE_BINARY_DIR}" "" b ${b})
-	install(CODE "file(CREATE_LINK ${CMAKE_INSTALL_PREFIX}/bin/git${EXE_EXTENSION} ${CMAKE_INSTALL_PREFIX}/libexec/git-core/${b}${EXE_EXTENSION})")
+	install(CODE "file(CREATE_LINK ${CMAKE_INSTALL_PREFIX}/bin/git${EXE_EXTENSION} ${CMAKE_INSTALL_PREFIX}/libexec/git-core/${b})")
 endforeach()
 
 foreach(b ${git_http_links})
 	string(REPLACE "${CMAKE_BINARY_DIR}" "" b ${b})
-	install(CODE "file(CREATE_LINK  ${CMAKE_INSTALL_PREFIX}/libexec/git-core/git-remote-http${EXE_EXTENSION} ${CMAKE_INSTALL_PREFIX}/libexec/git-core/${b}${EXE_EXTENSION})")
+	install(CODE "file(CREATE_LINK  ${CMAKE_INSTALL_PREFIX}/libexec/git-core/git-remote-http${EXE_EXTENSION} ${CMAKE_INSTALL_PREFIX}/libexec/git-core/${b})")
 endforeach()
 
 install(PROGRAMS ${git_shell_scripts} ${git_perl_scripts} ${CMAKE_BINARY_DIR}/git-p4
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 3 of 12 in “cmake: learn to optionally skip linking dashed built-ins”
  1. 0/4 cmake: learn to optionally skip linking dashed built-insJohannes Schindelin via GitGitGadget, Mar 27, 2021
  2. 1/4 cmake: support SKIP_DASHED_BUILT_INSJohannes Schindelin via GitGitGadget, Mar 27, 2021
  3. 2/4 cmake(install): fix double .exe suffixesDennis Ameling via GitGitGadget, Mar 27, 2021
  4. 3/4 cmake: add a preparatory work-around to accommodate `vcpkg`Johannes Schindelin via GitGitGadget, Mar 27, 2021
  5. Đoàn Trần Công DanhMar 28, 2021
  6. Johannes SchindelinMar 29, 2021
  7. 4/4 cmake(install): include vcpkg dllsDennis Ameling via GitGitGadget, Mar 27, 2021
  8. 0/4 cmake: learn to optionally skip linking dashed built-insJohannes Schindelin via GitGitGadget, Mar 29, 2021
  9. 1/4 cmake: support SKIP_DASHED_BUILT_INSJohannes Schindelin via GitGitGadget, Mar 29, 2021
  10. 2/4 cmake(install): fix double .exe suffixesDennis Ameling via GitGitGadget, Mar 29, 2021
  11. 4/4 cmake(install): include vcpkg dllsDennis Ameling via GitGitGadget, Mar 29, 2021
  12. 3/4 cmake: add a preparatory work-around to accommodate `vcpkg`Johannes Schindelin via GitGitGadget, Mar 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.