Re: [PATCH] describe: refresh the index when 'broken' flag is used

From

Abhijeet Sonar <abhijeet.nkt@gmail.com>

Date

Jun 24, 2024, 12:20 UTC

Message-ID

<69662b07-e216-421b-b947-afa52e56d7ec@gmail.com>

In-Reply-To

<054c6ac1-4714-4600-afa5-7e9b6e9b0e72@gmail.com>

On 24/06/24 16:50, Phillip Wood wrote:

> This is a good description of the problem the patch fixes.

Thanks!

> As we're dealing with a repository that might be broken I suspect we'd 
> be better to run "git update-index --unmerged -q --refresh" as a 
> subprocess in the same way that we run "git diff-index" so that "git 
> describe --broken" does not die if the index cannot be refreshed.

>> Also apart from that, we should add a test to capture the changes.
> That would be nice

Got it, I will add some tests as well.

Thanks