Re: [PATCH 1/2] fsmonitor: demonstrate that it is not refreshed after discard_index()

From: Johannes Sixt <j6t@kdbg.org>
Date: Mar 16, 2019, 10:26 UTC
Message-ID: <680444e1-d670-607b-e84b-c1eb4355b047@kdbg.org>
In-Reply-To: <f451752656ea5d1e9898e5fa0b2d41de6550781b.1552729745.git.gitgitgadget@gmail.com>

Am 16.03.19 um 10:49 schrieb Johannes Schindelin via GitGitGadget:

Show 11 quoted lines

> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
> index 3e0a61db23..918bc323ab 100755
> --- a/t/t7519-status-fsmonitor.sh
> +++ b/t/t7519-status-fsmonitor.sh
> @@ -346,4 +346,14 @@ test_expect_success UNTRACKED_CACHE 'ignore .git changes when invalidating UNTR'
>  	test_cmp before after
>  '
>  
> +test_expect_failure 'discard_index() also discards fsmonitor info' '
> +	test_when_finished \
> +		"git config core.monitor .git/hooks/fsmonitor-test" &&

Did you mean
		"git config core.fsmonitor ...
?

> +	test_config core.fsmonitor "$TEST_DIRECTORY/t7519/fsmonitor-all" &&

And then, does this not unset core.fsmonitor after the test anyway?

Show 7 quoted lines

> +	test_might_fail git update-index --refresh &&
> +	test-tool read-cache --print-and-refresh=tracked 2 >actual &&
> +	printf "tracked is%s up to date\n" "" " not" >expect &&
> +	test_cmp expect actual
> +'
> +
>  test_done

-- Hannes