git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/resend] Fix use of hardlinks in "make install"

From
AFAndreas Färber <planche2k@googlemail.com>
Date
Aug 30, 2008, 08:59 UTC
Message-ID
<66B007DD-F970-43E5-BA38-6138E553C93A@googlemail.com>
In-Reply-To
<20080830002032.GA14522@steel.home>
Am 30.08.2008 um 02:20 schrieb Alex Riesen:
Show 12 quoted lines
> The code failed to filter-out git-add properly on platforms were $X is
> not empty (ATM there is only one such a platform).
>
> Than it tried to create a hardlink to the file ($execdir/git-add) it  
> just
> removed (because git-add is first in the BUILT_INS), so ln failed (but
> because stderr was redirected into /dev/null the error was never  
> seen), and
> the whole install ended up using "ln -s" instead.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
Show 24 quoted lines
> Well, as usual, simple fix for a trivial typo caused by existence of  
> an
> idiotic platform.
>
> Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index bf400e6..20f028f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1379,7 +1379,7 @@ endif
> 	{ $(RM) "$$execdir/git-add$X" && \
> 		ln git-add$X "$$execdir/git-add$X" 2>/dev/null || \
> 		cp git-add$X "$$execdir/git-add$X"; } && \
> -	{ $(foreach p,$(filter-out git-add,$(BUILT_INS)), $(RM) "$$execdir/ 
> $p" && \
> +	{ $(foreach p,$(filter-out git-add$X,$(BUILT_INS)), $(RM) "$ 
> $execdir/$p" && \
> 		ln "$$execdir/git-add$X" "$$execdir/$p" 2>/dev/null || \
> 		ln -s "git-add$X" "$$execdir/$p" 2>/dev/null || \
> 		cp "$$execdir/git-add$X" "$$execdir/$p" || exit;) } && \
> -- 
> 1.6.0.1.152.g6969c

Your patch seems to work on Haiku, don't have a MinGW setup to test. Sorry for the breakage.

Andreas
Previous: Alex RiesenNext: Alex Riesen
Message 5 of 8 in “Fix use of hardlinks in "make install"”
  1. Fix use of hardlinks in "make install"Alex Riesen, Aug 28, 2008
  2. Alex RiesenAug 28, 2008
  3. Fix use of hardlinks in "make install"Alex Riesen, Aug 28, 2008
  4. Fix use of hardlinks in "make install"Alex Riesen, Aug 30, 2008
  5. Andreas FärberAug 30, 2008
  6. Alex RiesenAug 30, 2008
  7. Andreas FärberAug 30, 2008
  8. Alex RiesenAug 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.