git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 2/2] send-email: expose header information to git-send-email's sendemail-validate hook

From
LTLuben Tuikov <luben.tuikov@amd.com>
Date
Apr 19, 2023, 18:05 UTC
Message-ID
<668c657a-34e1-fa70-e448-5c297fc506d4@amd.com>
In-Reply-To
<xmqqttxb956n.fsf@gitster.g>
On 2023-04-19 13:01, Junio C Hamano wrote:
Show 22 quoted lines
> Michael Strawbridge <michael.strawbridge@amd.com> writes:
> 
>>>> +Below is an example for a few common headers. Take notice of the
>>> "example of" not "for".
>>>
>>> This maybe clearer:
>>> "An example of a few common headers is shown below. Take notice ..."
>> ...
>>>> +test_expect_success $PREREQ "--validate hook supports header argument" '
>>>> +	write_script my-hooks/sendemail-validate <<-\EOF &&
>>>> +        if test "$#" -ge 2
>>>> +	then
>>> There appears to be an extra indentation of the "if" statement.
>> Good catch.  It was a matter of spaces and tabs combining that wasn't
>> easy to see.
> 
> I was reading the list of stalled topics in the periodical "What's
> cooking" report and noticed that this topic has been marked as
> "Expecting a hopefully minor and final reroll." for full three
> months after we saw this message.  Should we be waiting more?
> 
> Thanks.

Thanks Junio for the reminder--I was wondering the same thing not so long ago.

We'll re-roll it and submit it for inclusion.
-- 
Regards,
Luben
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 7 of 10 in “send-email: expose header information to git-send-email's sendemail-validate hook”
  1. 0/2 send-email: expose header information to git-send-email's sendemail-validate hookMichael Strawbridge, Jan 20, 2023
  2. 1/2 send-email: refactor header generation functionsMichael Strawbridge, Jan 20, 2023
  3. 2/2 send-email: expose header information to git-send-email's sendemail-validate hookMichael Strawbridge, Jan 20, 2023
  4. Luben TuikovJan 20, 2023
  5. Michael StrawbridgeJan 20, 2023
  6. Junio C HamanoApr 19, 2023
  7. Luben TuikovApr 19, 2023
  8. Ævar Arnfjörð BjarmasonJan 23, 2023
  9. Michael StrawbridgeJan 23, 2023
  10. Ævar Arnfjörð BjarmasonJan 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.