Re: [PATCH v9 2/2] send-email: expose header information to git-send-email's sendemail-validate hook
- From
- Luben Tuikov <luben.tuikov@amd.com>
- Date
- Apr 19, 2023, 18:05 UTC
- Message-ID
- <668c657a-34e1-fa70-e448-5c297fc506d4@amd.com>
- In-Reply-To
- <xmqqttxb956n.fsf@gitster.g>
On 2023-04-19 13:01, Junio C Hamano wrote:
Show 22 quoted lines
> Michael Strawbridge <michael.strawbridge@amd.com> writes: > >>>> +Below is an example for a few common headers. Take notice of the >>> "example of" not "for". >>> >>> This maybe clearer: >>> "An example of a few common headers is shown below. Take notice ..." >> ... >>>> +test_expect_success $PREREQ "--validate hook supports header argument" ' >>>> + write_script my-hooks/sendemail-validate <<-\EOF && >>>> + if test "$#" -ge 2 >>>> + then >>> There appears to be an extra indentation of the "if" statement. >> Good catch. It was a matter of spaces and tabs combining that wasn't >> easy to see. > > I was reading the list of stalled topics in the periodical "What's > cooking" report and noticed that this topic has been marked as > "Expecting a hopefully minor and final reroll." for full three > months after we saw this message. Should we be waiting more? > > Thanks.
Thanks Junio for the reminder--I was wondering the same thing not so long ago.
We'll re-roll it and submit it for inclusion.
-- Regards, Luben