Re: fsck: BAD_FILEMODE diagnostic broken / never triggers

From: Xavier Morel <xavier.morel@masklinn.net>
Date: Aug 10, 2022, 15:01 UTC
Message-ID: <6688857F-B899-4253-933B-0DFE25155D13@masklinn.net>
In-Reply-To: <YvLttyyaZWm4pitu@coredump.intra.peff.net>

>> We probably need to provide version of decode_tree_entry() which gives
>> the non-canonical mode, and to call it from fsck.

That makes sense.

> Perhaps something like the patch below.

I fear I'm really not able to judge so I'll let you fine folks decide on what to do.

> Note that these are treated with a severity of "warning", so fsck won't
> give a non-zero exit.

Yeah from what I understand it is classified as a warning already (just not emitted), like the zero padded filemodes. And that can be upgraded to error using fsck.msgid=error so shouldn't be an issue.

> I think it still enough for transfer.fsckObjects
> to mark them. I kind of wonder if fixing this at this point might create
> more problems than it solves though (e.g., if people have broken modes
> in historical objects that servers may now reject).

Maybe downgrade to info or ignore by default then? It might still be an issue for people who wilfully upgraded the diagnostic to error hoping to catch the, but hopefully if they did that they'd rather get the notice later than never?

That's pretty much the `-Werror` problem (or one of them anyway)