git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add a test for a problem in "rebase --whitespace=fix"

From
Björn Gustavsson <bgustavsson@gmail.com>
Date
Feb 10, 2010, 20:20 UTC
Message-ID
<6672d0161002101220h34ebbda8o3fde503d41c8313e@mail.gmail.com>
In-Reply-To
<7vzl3i137f.fsf@alter.siamese.dyndns.org>
2010/2/9 Junio C Hamano <gitster@pobox.com>:
> I actually changed my mind after thinking about it a bit more.

Thanks for thinking more about it and for your explanation about the algorithm

I am quite busy at the moment, but I hope to get started on a patch series after the end of February.

> I'd like to see this logic (and only this logic, without relying on the
> diff hunk offset numbers at all) done first, because it is very much in
> line with what we already do, and more importantly, because it is a more
> general solution that is applicable outside the context of rebase.

I'll try to implement that logic. It seems that it should cover 99% of all real-world use cases. I will not worry about the general case (tons of blanks) until I have got the first patch working.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
Previous: Junio C Hamano
Message 7 of 7 in “Add a test for a problem in "rebase --whitespace=fix"”
  1. Add a test for a problem in "rebase --whitespace=fix"Björn Gustavsson, Feb 7, 2010
  2. Junio C HamanoFeb 7, 2010
  3. Björn GustavssonFeb 7, 2010
  4. Junio C HamanoFeb 8, 2010
  5. Björn GustavssonFeb 8, 2010
  6. Junio C HamanoFeb 9, 2010
  7. Björn GustavssonFeb 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.