git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 4/4] Re-implement 'git remote update' using 'git fetch'

From
Björn Gustavsson <bgustavsson@gmail.com>
Date
Nov 8, 2009, 22:23 UTC
Message-ID
<6672d0160911081423u41f7faa6md50190b04a71069d@mail.gmail.com>
In-Reply-To
<hd7c4k$aul$3@ger.gmane.org>
On Sun, Nov 8, 2009 at 10:10 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
Show 9 quoted lines
> On 11/08/2009 04:48 PM, Björn Gustavsson wrote:
>> There is one incompatibility: the skipDefaultUpdate configuration
>> variable will only be honored if remotes.default is not set (i.e.
>> when 'git remote update' will invoke 'git fetch --all', not when
>> it will invoke 'git fetch default').
>
> Rather than introducing this incompatibility, I'd rather see 'git remote
> update' deprecated (so that the code will one day go away for good) and, for
> now, leave duplicated functionality for the incompatible case.

I didn't check my facts properly before writing that commit message. Looking again at the old code in builtin_remote.c (after a long break), and actually testing the behavior, I see that there is no incompatibility.

Both the old and the new code use skipDefaultUpdate only if remotes.default is not set. If remotes.default is set, that list of remotes will be used. Only if remotes.default is not set, will 'git remote update' go through the list of all remotes and filter away those that have skipDefaultUpdate set to true.

Sorry for the confusion. I will correct the commit message in my re-roll of the patch.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
Previous: Paolo BonziniNext: Jay Soffian
Message 3 of 5 in “Re-implement 'git remote update' using 'git fetch'”
  1. 4/4 Re-implement 'git remote update' using 'git fetch'Björn Gustavsson, Nov 8, 2009
  2. Paolo BonziniNov 8, 2009
  3. Björn GustavssonNov 8, 2009
  4. Jay SoffianNov 9, 2009
  5. Björn GustavssonNov 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.