git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] Add userdiff built-in pattern for CSS code

From
WDWilliam Duclot <william.duclot@ensimag.grenoble-inp.fr>
Date
May 19, 2016, 18:10 UTC
Message-ID
<666636251.5761714.1463681429687.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<CAPig+cQcK4x+u=PjxGAAPnAgqCAxLHrvbH8Pqgjgd9aAe85g7g@mail.gmail.com>
Show 11 quoted lines
> On Thu, May 19, 2016 at 10:45 AM, Matthieu Moy
> <matthieu.moy@grenoble-inp.fr> wrote:
> >> Add the info in documentation that CSS is now built-in.
> >
> > This doesn't add much to the patch (we can already see that from the patch
> > itself). I'd remove it.
> 
> I think you meant to say this "doesn't add much to the *commit
> message*", and that the sentence should be removed from the commit
> message, while retaining the actual documentation update in the patch.
> 
That's of course how I understood it, but thanks for pointing it out !
Beside that, all of Matthieu Moy comments seem correct to me and will be taken into account.
Previous: Eric Sunshine
Message 4 of 4 in “Add userdiff built-in pattern for CSS code”
  1. Add userdiff built-in pattern for CSS codeWilliam Duclot, May 19, 2016
  2. Matthieu MoyMay 19, 2016
  3. Eric SunshineMay 19, 2016
  4. William DuclotMay 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.