Re: git-p4 and keyword expansion
Hello,
----- Original Message ----
Show 10 quoted lines
> From: Jing Xue <jingxue@digizenstudio.com>
> To: dhruva <dhruva@ymail.com>
> Cc: GIT SCM <git@vger.kernel.org>
> Sent: Tuesday, 9 September, 2008 3:09:00 AM
> Subject: Re: git-p4 and keyword expansion
> > Removing the keyword unexpanding code in 'git-p4' with the
> > following patch makes it work:
>
> I'm not really arguing against the patch itself, but just wondering
> whether it would be a good idea to make it optional or configurable.
I feel the configuration must be set the first time only, when you clone using 'git-p4 clone'. Altering it in between will be very confusing! Ideally, the setting must be transferred when the git repo (cloned from git-p4) is cloned using standard git. Is it something possible (well, I am new to git and am exploring. Any extra information would help).
My proposal is as follows:
1. Add an extra command line argument to 'git-p4 clone' to either enable/disable keyword expansion
2. Store that information under the .git folder in a file that is copied when someone clones that repo
3. Use the stored information in future 'git-p4 sync/rebase'
> IIUC, there are reasons for git to discourage keyword expansion - for
> instance as discussed in this thread:
>
> http://kerneltrap.org/mailarchive/git/2007/10/11/335112
I agree that keyword expansion is bad but there is no alternative when you work with a system that has keyword expansion and you need interoperability (p4<->git)
-dhruva
Unlimited freedom, unlimited storage. Get it now, on http://help.yahoo.com/l/in/yahoo/mail/yahoomail/tools/tools-08.html/