Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Nov 21, 2017, 12:36 UTC
Message-ID: <654367f1-bc59-d546-a37d-dcb8f13ca65e@jeffhostetler.com>
In-Reply-To: <b1037774-6ae6-630b-f330-e95b1c3d681d@ramsayjones.plus.com>

On 11/20/2017 6:39 PM, Ramsay Jones wrote:

Show 17 quoted lines

> 
> In particular, sparse complains that the armor_{en,de}code_arg()
> functions are 'not declared - should they be static?'. Since the
> armor_decode_arg() symbol does not require more than file visibility,
> we can simply mark the declaration with static. The armor_encode_arg()
> function has no callers, so we simply remove the (unused) definition.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Jeff,
> 
> If you need to re-roll your 'jh/object-filtering' branch, could you
> please squash this (or something like it) into the relevant patch
> (commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list",
> 16-11-2017).
>

thanks for the note. i'm going to remove these functions completely in my next version. it was decided that we don't need to do encoding/decoding at this level.

Thanks, Jeff