git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 1/3] t0021: avoid grepping for a Perl-specific string at filter output

From
Matheus Tavares <matheus.bernardino@usp.br>
Date
Aug 15, 2022, 01:06 UTC
Message-ID
<64dc9af1ad90c31e988ea8d6ece4a23a930d57d0.1660522524.git.matheus.bernardino@usp.br>
In-Reply-To
<cover.1660522524.git.matheus.bernardino@usp.br>

This test sets the t0021/rot13-filter.pl script as a long-running process filter for a git checkout command. It then expects the filter to fail producing a specific error message at stderr. In the following commits we are going to replace the script with a C test-tool helper, but the test currently expects the error message in a Perl-specific format. That is, when you call `die <msg>` in Perl, it emits "<msg> at - line 1." In preparation for the conversion, let's avoid the Perl-specific part and only grep for <msg> itself.

Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
---
 t/t0021-conversion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh
index 1c840348bd..963b66e08c 100755
--- a/t/t0021-conversion.sh
+++ b/t/t0021-conversion.sh
@@ -735,7 +735,7 @@ test_expect_success PERL 'process filter should restart after unexpected write f
 		rm -f debug.log &&
 		git checkout --quiet --no-progress . 2>git-stderr.log &&
 
-		grep "smudge write error at" git-stderr.log &&
+		grep "smudge write error" git-stderr.log &&
 		test_i18ngrep "error: external filter" git-stderr.log &&
 
 		cat >expected.log <<-EOF &&
-- 
2.37.1
Previous: Matheus TavaresNext: Matheus Tavares
Message 2 of 6 in “t0021: convert perl script to C test-tool helper”
  1. 0/3 t0021: convert perl script to C test-tool helperMatheus Tavares, Aug 15, 2022
  2. 1/3 t0021: avoid grepping for a Perl-specific string at filter outputMatheus Tavares, Aug 15, 2022
  3. 2/3 t0021: implementation the rot13-filter.pl script in CMatheus Tavares, Aug 15, 2022
  4. 3/3 tests: use the new C rot13-filter helper to avoid PERL prereqMatheus Tavares, Aug 15, 2022
  5. Johannes SchindelinAug 15, 2022
  6. Junio C HamanoAug 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.