Re: [PATCH v5] userdiff: add builtin diff driver for kotlin language.

From: Jaydeep Das <jaydeepjd.8914@gmail.com>
Date: Mar 10, 2022, 16:29 UTC
Message-ID: <64677295-e7fd-ba4b-ce68-fe62132ca504@gmail.com>
In-Reply-To: <72aca675-4c65-36bf-1337-34b2d1f40bb4@kdbg.org>

On 3/9/22 00:02, Johannes Sixt wrote:

Show 17 quoted lines

> Am 08.03.22 um 17:54 schrieb jaydeepjd.8914@gmail.com:
>> So, the final regexes are these, right?:
> 
> Not quite.
> 
>>
>>       "[a-zA-Z_][a-zA-Z0-9_]*"
>>       /* hexadecimal and binary numbers */
>>       "|0[xXbB][0-9a-fA-F_]+[lLuU]*"
>>       /* integers and floats */
>>       "|[0-9][.]?[0-9_]+([Ee][-+]?[0-9]+)?[fFlLuU]*"
> 
> This would not match 12.5 because you allow only a single digit before
> the decimal point. Perhaps
> 
> 	"|[0-9][.0-9_]*([Ee][-+]?[0-9]+)?[fFlLuU]*"
>

The problem with this approach is that it matches `2..5` as a single token. However in Kotlin, `..` is used to specify a range so 2..5 should be broken into 2 .. and 5.