git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: remove custom callouts format

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 18, 2023, 07:25 UTC
Message-ID
<643e45d9222ae_21b04329432@chronos.notmuch>
In-Reply-To
<20230418044142.GA130759@coredump.intra.peff.net>
Jeff King wrote:
Show 13 quoted lines
> On Tue, Apr 18, 2023 at 12:00:34AM -0400, Jeff King wrote:
> 
> > It's probably still worth moving forward with your patch, as I think it
> > takes us in the direction we want long-term (and which builds with
> > asciidoctor are already using). But we may want to pair it with a patch
> > to work around the issue with git-checkout.1 using asciidoc to avoid
> > regressing that section. It may require re-wording or re-organizing to
> > work around the bug.
> 
> Just to clarify my comment on asciidoctor: since our Makefile will put
> its output through docbook, too, it actually is using the xsl you're
> removing here (though I'm unclear on why its output looks good in
> general even before your patch).

It's probably a quirk of the git hack for callouts, but that's specific to manpages.

Have you looked at the HTML output generated by asciidoc-py? The badly indented output suggests this issue has nothing to do with my patch.

-- 
Felipe Contreras
Previous: Jeff KingNext: Felipe Contreras
Message 4 of 9 in “doc: remove custom callouts format”
  1. doc: remove custom callouts formatFelipe Contreras, Apr 18, 2023
  2. Jeff KingApr 18, 2023
  3. Jeff KingApr 18, 2023
  4. Felipe ContrerasApr 18, 2023
  5. Felipe ContrerasApr 18, 2023
  6. Jeff KingApr 18, 2023
  7. Felipe ContrerasApr 18, 2023
  8. Jeff KingApr 18, 2023
  9. Felipe ContrerasApr 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.