Re: [PATCH 06/18] version-gen: remove redundant check

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 14, 2023, 17:47 UTC
Message-ID: <643991c58aef_5ecfe29433@chronos.notmuch>
In-Reply-To: <ZDltLSTxBCWRoMjK@pobox.com>

Todd Zullinger wrote:

Show 6 quoted lines

> Felipe Contreras wrote:
> > If we are not in a git repository `git describe` will fail anyway.
> 
> The parent directory may be a git repository though.  The
> current code ensures that we're running `git describe` in
> the proper repository.

How exactly does it do that?

The current code expects the cwd to be the git repo, run it in any other directory and it will generate GIT-VERSION-FILE in that directory, which is clearly not intended.

> If we drop this, aren't we breaking things for someone
> building a git tarball which is in a subdirectory of a git
> repository?

How exactly would this hypothetical person build such a tarball?

  git init /tmp/foo
  mkdir -p /tmp/foo/bar
  cd /tmp/foo/bar
  make -C ~/dev/git dist

Works fine.

-- 
Felipe Contreras