RE: Make test on AIX

From: Craig L. Ching <cching@mqsoftware.com>
Date: Jun 28, 2008, 15:35 UTC
Message-ID: <63BEA5E623E09F4D92233FB12A9F7943013D8B@emailmn.mqsoftware.com>
In-Reply-To: <20080628051500.GF9451@sigill.intra.peff.net>

(I apologize in advance if the quoting is bad, using owa since I don't want an outlook client installed on my home system)

-----Original Message-----
From: git-owner@vger.kernel.org on behalf of Jeff King
Sent: Sat 6/28/2008 12:15 AM
To: Craig L. Ching
Cc: git@vger.kernel.org
Subject: Re: Make test on AIX
 
On Fri, Jun 27, 2008 at 04:13:41PM -0500, Craig L. Ching wrote:

Show 6 quoted lines

> The first thing I encountered was that because the tests all use
> #!/bin/sh the exit code was not what the tests expected.  So I ended up
> running 'make SHELL=`which bash` all' directly in the git/t/ directory.
> That seemed to shake out and work for most of the tests except for
> t/t7502-commit.sh.  Try as I might, I could not get SHELL_PATH set to
> anything but /bin/sh except to hard-code the SHELL_PATH in this script.

> > The SHELL_PATH actually comes from the build options for all of git. So
> > you should be able to go to the toplevel of your git repo and do a "make
> > SHELL_PATH=`which bash`". This means that we will also use bash for all
> > of the script components of git.

Well, I swear I tried 'make SHELL_PATH=`which bash` test' and that *didn't* work, but I just rebuilt adding SHELL_PATH to even the build step and the tests are running.  I do know I upgraded bash somewhere in between trying that and now, maybe that had some affect, the bash that was installed was fairly old.  The tests are running now, I'll post back if I run into any other problems.

> > I don't know how necessary that is on AIX, but it certainly is on
> > Solaris, where /bin/sh is unusable.

I didn't have this problem at all on Solaris, the tests ran just great apart from needing to install a pretty hefty GNU tool chain since a lot of the tests wouldn't work with non-GNU equivalents (e.g. patch, diff, sed, etc.).  Not a huge deal, just glad to see it building and passing tests on these platforms ;-)

> > -Peff

Thanks again!

Cheers, Craig