Re: [RFC PATCH 2/3] connect: group CONNECT_DIAG_URL handling code

From: Torsten Bögershausen <tboegi@web.de>
Date: Apr 29, 2016, 20:00 UTC
Message-ID: <632a7629-645b-43a7-abd7-fcbc35362f60@web.de>
In-Reply-To: <1461890625-23222-2-git-send-email-mh@glandium.org>

On 29.04.16 02:43, Mike Hommey wrote:

> get_host_and_port(&ssh_host, &port);
> +			if (!port)
> +				port = get_port(ssh_host);

I'm not sure, if this is an improvement or not.

The original intention was, to check what the parser did, before going out to the external program (like ssh) or opening a socket.

Everything should be prepared, as if the action had been taken, and in the last nanosecond we jump out and print what would have been done. (The nanosecond may depend on the CPU speed)

In any case, for SSH there should be only one line calling get_host_and_port(), or get_port().

This is to check the complete logic path in test cases, as well as it allows the user to check the URL, especially when using SSH.

Splitting the logic into a path where we just print and one, where the connection is really made, looses "single point of truth" - we don't know any longer, what we test or print for diag.