Re: [PATCH] describe-doc: clarify default length of abbreviation
On Sun, May 16, 2021, at 14:58, Junio C Hamano wrote:
Show 15 quoted lines
> Anders Höckersten <anders@hockersten.se> writes:
>
> > The explanation was mostly copied from the 2.11.0 release notes,
> > but mentioning the birtday paradox is unnecessary. I suggest
> > changing this sentence to: "The length of the abbreviation scales
> > as the repository grows using the approximate number of objects in
> > the repository, and by default the minimum length is 7."
>
> Heh. In my priate review, I said that I very much liked the way the
> new description was phrased with "a bit of math around the birthday
> paradox". Now I know why I liked that phrasing---it turns out to be
> my own ;-)
>
> I don't mind with or without mention of the birthday math. Thanks
> for working on this.
Actually, changed my mind again. I like the phrasing and it's in the "examples" section so a bit of verbosity doesn't hurt. Will submit a new patch with the other changes mentioned + whitespace fixes momentarily.
/A
Anders Höckersten <anders@hockersten.se>