RE: [PATCH] completion: avoid config variable name lookup error in nounset mode

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Aug 11, 2021, 19:40 UTC
Message-ID: <611427b9cd4f1_19f82088b@natae.notmuch>
In-Reply-To: <20210811191637.775693-1-ville.skytta@iki.fi>

Ville Skyttä wrote:

Show 21 quoted lines

> Config variable name lookup accesses the `sfx` variable before it has
> been set, causing an error in "nounset" mode. Initialize to an empty
> string to avoid that.
> 
>     $ git config submodule.<Tab>bash: sfx: unbound variable
> 
> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 4bdd27ddc8..ecc9352755 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2631,7 +2631,7 @@ __git_complete_config_variable_value ()
>  #                 subsections) instead of the default space.
>  __git_complete_config_variable_name ()
>  {
> -	local cur_="$cur" sfx
> +	local cur_="$cur" sfx=""

For what it's worth this would break a fix I've sent several times already [1].

The proper fix requires changing __gitcomp as well, after that sfx can simply be " ".

All the patches that fix all these issues have been sent, and if you want to try them out check git-completion [2].

Cheers.

[1] https://lore.kernel.org/git/20210707023146.3132162-5-felipe.contreras@gmail.com/ [2] https://github.com/felipec/git-completion

-- 
Felipe Contreras