Re: [PATCH 1/9] t7601: add relative precedence tests for merge and rebase flags/options

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jul 20, 2021, 20:29 UTC
Message-ID: <60f73213233d7_14a799208f5@natae.notmuch>
In-Reply-To: <xmqq35samac9.fsf@gitster.g>

Junio C Hamano wrote:

> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

> > +test_expect_failure '--no-rebase overrides pull.ff=only' '
> > +	test_does_need_full_merge -c pull.ff=only pull --no-rebase
> > +'
> > +
> > +test_expect_success '--rebase takes precedence over pull.ff=only' '
> > +	test_does_rebase -c pull.ff=only pull --rebase
> > +'
> 
> OK.

Since when is it OK to test for a new behavior that 1. will break compatibility, 2. is not documented, and 3. has zero consensus?

-- 
Felipe Contreras

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.