Re: [PATCH] commit: remove irrelavent prompt on `--allow-empty-message`

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jul 7, 2021, 04:37 UTC
Message-ID: <60e52f945507_2fe63d2088c@natae.notmuch>
In-Reply-To: <xmqqlf6jla5o.fsf@gitster.g>

Junio C Hamano wrote:

Show 14 quoted lines

> Hu Jialun <hujialun@comp.nus.edu.sg> writes:
> 
> > Currently, COMMIT_EDITMSG contains "...and an empty message aborts the
> > commit", regardless of whether the --allow-empty-message option is
> > specified or not. This is deemed confusing and unintended.
> 
> I have to wonder what reason a user have to use that option, other
> than wanting to record a commit without any message.  In other words,
> wouldn't it be a bug for this command 
> 
>     $ git commit --allow-empty-message
> 
> to open an editor to allow editing the message, instead of just
> committing with an empty message?

To translate this question into more programmatical terms.

Should this commit an empty message?

  % git commit --allow-empty-message -m "$msg"

I say the answer is no.

We need to know what the message is.

-- 
Felipe Contreras