git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] completion: bash: fix late declaration of __git_cmd_idx

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 18, 2021, 19:09 UTC
Message-ID
<60ccef865312e_a69392081a@natae.notmuch>
In-Reply-To
<20210618140256.256481-1-fabianw@mavt.ethz.ch>
Fabian Wermelinger wrote:
> A recent update to contrib/completion/git-completion.bash causes bash to fail
> auto complete custom commands that are wrapped with __git_func_wrap. Declaring
> __git_cmd_idx=0 inside __git_func_wrap resolves the issue.

I was about to say the idx should be 1, and that fixes the issue, but actually 0 is more correct, since when we do __git_complete there's actually no real command.

In the future we might want to improve __git_complete to manufacture a real command since some completions do check the command at __git_cmd_idx (e.g. __git_complete_remote_or_refspec), and then set __git_cmd_idx to 1.

But for now your patch fixes the issue better than my previous patch [1], however, it's still missing the zsh part. I've sent an update patch with the best of both [2].

Cheers.

[1] https://lore.kernel.org/git/20210618182518.697912-2-felipe.contreras@gmail.com/ [2] https://lore.kernel.org/git/20210618185832.700477-1-felipe.contreras@gmail.com/

Cheers.
-- 
Felipe Contreras
Previous: Fabian Wermelinger
Message 2 of 2 in “completion: bash: fix late declaration of __git_cmd_idx”
  1. completion: bash: fix late declaration of __git_cmd_idxFabian Wermelinger, Jun 18, 2021
  2. Felipe ContrerasJun 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.