Re: What's cooking in git.git (Jun 2021, #06; Thu, 17)

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 18, 2021, 04:20 UTC
Message-ID: <60cc1efb4f691_5d7b82086d@natae.notmuch>
In-Reply-To: <YMvhoXVBoO08ziI1@camp.crustytoothpaste.net>

brian m. carlson wrote:

Show 11 quoted lines

> On 2021-06-17 at 02:55:26, Junio C Hamano wrote:
> > * bc/doc-asciidoctor-to-man-wo-xmlto (2021-05-14) 2 commits
> >  - doc: remove GNU_ROFF option
> >  - doc: add an option to have Asciidoctor build man pages directly
> > 
> >  An option to render the manual pages via AsciiDoctor bypassing
> >  xmlto has been introduced.
> > 
> >  What is the status of this one?
> 
> Probably best to drop it.

> I think Felipe didn't want his sign-off on it, and I don't think
> there's a good way to produce an equivalent patch without
> incorporating his changes.

I explained very clearly what I would expect to happen for this patch to be valid [1]; you don't need to drop the patch, simply state that *you* wrote the commit message, not me.

Here, I'm copying *exactly* what I wrote so there's no confusion:

  Hard to tell in this frankenstein commit. I'd be fine with a
  Commit-message-by line.

> We don't seem to see eye to eye on an appropriate solution to the
> problem, and I don't feel like arguing about it further.

I don't see what is the big problem. I said you should split your patch into multiple patches, since I believe your patch is doing multiple unlrelated changes at once.

In fact, your patches don't not apply to master anymore (since you made too many changes), while my patch series [2] does apply cleanly.

I don't mind our competening series to hash it out again, but first you need to send another round which does applie cleanly on top of master--unlike your previous one. And then I'd comment my objections to it, yet again.

Cheers.

[1] https://lore.kernel.org/git/609b5c85b7c61_678ff20848@natae.notmuch/ [2] https://lore.kernel.org/git/20210608090026.1737348-1-felipe.contreras@gmail.com/

-- 
Felipe Contreras