RE: [PATCH v2 0/4] show-branch: add missing tests, trivial color output change

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 17, 2021, 21:46 UTC
Message-ID: <60cbc2cfde385_12992083@natae.notmuch>
In-Reply-To: <cover-0.4-0000000000-20210617T105245Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> This v2 doesn't change any of the code (see range-diff), but better
> explains the change per Michael J Gruber's feedback in
> https://lore.kernel.org/git/162374905722.40525.516266574605586007.git@grubix.eu/
> 
> There's also a trivial grammar fix, s/add/odd/g.
> 
> Ævar Arnfjörð Bjarmason (4):
>   show-branch tests: rename the one "show-branch" test file
>   show-branch tests: modernize test code
>   show-branch: don't <COLOR></RESET> for space characters
>   show-branch tests: add missing tests

All these look good to me (I would prefer patch #2 to be split into multiple patches, but that's not a deal-breaker).

Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>

-- 
Felipe Contreras