git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] extra: new concept of extra components

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 16, 2021, 20:28 UTC
Message-ID
<60ca5ef868f40_60272086d@natae.notmuch>
In-Reply-To
<87tum0zfub.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
Show 19 quoted lines
> 
> On Sun, Jun 13 2021, Felipe Contreras wrote:
> 
> > This patch series introduces the concept of extra components. These are
> > components which are not yet part of the core but are good enough for
> > distributions to ship, and in fact, they already do.
> 
> I like this direction.
> 
> > The measuring stick I'm using to gauge if a component in contrib belongs
> > in extra is simple: are we already running tests for them with
> > 'make test'?
> 
> I have a CI failure in one series of mine that seems to be a lack of
> updating to CMake in contrib/buildsystems, perhaps we should be adding
> that to extra/ too, i.e. extending this to the "make test" run by CI?
> 
> Not something that should hinder or necessarily be included in this
> series, just a note about a related component.
Yeah, but then it would be less clear which components belong in extra.

I suppose if `make test` also runs the test-extra target, then the my initial definition of extra is still maintained.

Show 6 quoted lines
> > And we might move some components from the core which aren't realy part
> > of the core to extra, like gitk, git-gui, git-p4, and git-svn.
> 
> I'd also like to see us run the tests for the likes of mw-to-git,
> diff-highlight and subtree by default, at least under CI or some
> "extended tests" mode, even though we may not install them by default.

extra components are not installed by default, you would have to do install-extra.

Do you think mw-to-git and similar should be installed with install-extra?

-- 
Felipe Contreras
Previous: Felipe Contreras
Message 9 of 9 in “extra: new concept of extra components”
  1. 0/2 extra: new concept of extra componentsFelipe Contreras, Jun 14, 2021
  2. 1/2 completion: graduate out of contribFelipe Contreras, Jun 14, 2021
  3. Ævar Arnfjörð BjarmasonJun 14, 2021
  4. Felipe ContrerasJun 16, 2021
  5. 2/2 git-new-workdir: graduate out of contribFelipe Contreras, Jun 14, 2021
  6. Ævar Arnfjörð BjarmasonJun 14, 2021
  7. Junio C HamanoJun 16, 2021
  8. Felipe ContrerasJun 16, 2021
  9. Felipe ContrerasJun 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.