Re: [PATCH 2/2] comments: avoid using the gender of our users

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jun 15, 2021, 16:36 UTC
Message-ID: <60c8d713faf2_1296f20819@natae.notmuch>
In-Reply-To: <94ce6d7d-f923-edb3-12f5-4b11149c9f6f@gmail.com>

Derrick Stolee wrote:

Show 6 quoted lines

> On 6/11/2021 4:28 PM, Felipe Contreras wrote:
> > We generally avoid specifying the gender of our users in order to be
> > more politically correct, but sometimes due to lack of time and/or
> > creativity a few slip by.
> 
> s/politically correct/inclusive/

I don't believe avoiding pronouns makes us more inclusive, and I've yet to see an example where any person would feel personally excluded from.

> Instead of "lack of time and/or creativity" perhaps be more
> generous to our fellow contributors and instead say...

I believe my wording is more generous because it implies they tried, whereas yours implies they didn't even try.

Show 12 quoted lines

>   but sometimes a few slip by due to habit.
> 
> > @@ -908,7 +908,7 @@ int parse_expiry_date(const char *date, timestamp_t *timestamp)
> >  		/*
> >  		 * We take over "now" here, which usually translates
> >  		 * to the current timestamp.  This is because the user
> > -		 * really means to expire everything she has done in
> > +		 * really means to expire everything that has been done in
> 
> nit: s/has been/was/
> 
> We can be a little more active here.

True. That's probably better.

Cheers.

-- 
Felipe Contreras