Re: The git spring cleanup challenge

From

Felipe Contreras <felipe.contreras@gmail.com>

Date

Jun 2, 2021, 04:53 UTC

Message-ID

<60b70eb930614_4abd208ad@natae.notmuch>

In-Reply-To

<YLcFU+ORZTzAsyBy@danh.dev>

Đoàn Trần Công Danh wrote:

> On 2021-06-01 05:48:41-0500, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > > How about alias? It's part of my muscle memory.
> > 
> > No aliases.
> > 
> > If a new user doesn't have them, neither should you.
> > 
> > All VCSs have default aliases, and I advocated for git to do the same
> > [1], but it wasn't accepted.
> > 
> > The whole point is to suffer like them.
> 
> Get back to the alias topic.
> I also agree with other people's opinion in that thread.
> IOW, I support the decision to not accept those default alias ;)

Why?

> It's not required to be different people to have alias defined to
> different command. I have alias conditionally defined to different
> command based on git-dir. For example, I had ci alias to "commit" by
> default, and "commit -s" on other repositories.

So? They would still work.

> So, Git decides alias for me will not only break my current alias, but
> also break my conditional alias.

Try it.

--- a/alias.c
+++ b/alias.c
@@ -28,13 +28,27 @@ static int config_alias_cb(const char *key, const char *value, void *d)
        return 0;
 }
 
+struct config_alias_data default_aliases[] = {
+       { "co", "checkout" },
+       { "ci", "checkout" },
+       { "rb", "rebase" },
+       { "st", "status" },
+};
+
 char *alias_lookup(const char *alias)
 {
        struct config_alias_data data = { alias, NULL };
+       int i;
 
        read_early_config(config_alias_cb, &data);
+       if (data.v)
+               return data.v;
+       for (i = 0; i < ARRAY_SIZE(default_aliases); i++) {
+               if (!strcmp(alias, default_aliases[i].alias))
+                       return xstrdup(default_aliases[i].v);
+       }
 
-       return data.v;
+       return NULL;
 }
 
 void list_aliases(struct string_list *list)


> Anyway, remotes/branches are all configuration values.
> Would you prefer:

I meant global configurations. If it's a per-repository setting surely
it wouldn't be something amenable for the Git project to set as default.

-- 
Felipe Contreras