git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] strbuf: add strbuf_add_uint()

From
René Scharfe <l.s.r@web.de>
Date
May 12, 2026, 19:32 UTC
Message-ID
<60b1ef2a-3b12-449e-be0b-cb206425c80c@web.de>
In-Reply-To
<20260512184238.GC70851@coredump.intra.peff.net>
On 5/12/26 8:42 PM, Jeff King wrote:
Show 12 quoted lines
> On Tue, May 12, 2026 at 01:56:00PM +0200, René Scharfe wrote:
> 
>> Prepare the number string in a temporary buffer.  Make it big enough for
>> any unsigned integer value: A decimal digit can represent ln(10)/ln(2) ≈
>> 3.32 bits; dividing the number of bits of uintmax_t by 3.3 and rounding
>> up gives a sufficiently close conservative size estimate.
> 
> Cute. The naive obvious question here is: why not just grow the strbuf
> and format it there directly?
> 
> And the answer is that it's much easier to format numbers right-to-left,
> and then you know how many digits you need. ;)

Right. Using the strbuf to format the number at the right end and memmove()ing it in place is a valid approach. I expected it to be faster than using a buffer on the stack because there's a chance that only one cache line needs to be touched.

> You can compute the number of digits needed up front, of course, but
> it's log-10. You might be able to do it quickly based on the size of the
> leading bit, but there are a lot of off-by-one gotchas.

That's the simplest approach and I expected the few necessary extra divisions to be faster than using a buffer and having to copy the result.

The three variants were close in my tests, the no-copy variant slightly winning on Apple silicon, but losing slightly more on an AMD Ryzen laptop CPU. So I went with the solid choice of using an on-stack buffer, same as in printf(3) (at least on BSD). Buffering at the end of the strbuf was not really faster; perhaps memmove(3) is just that much slower than memcpy(3).

Perhaps an optimized decimal_width() could change the picture somewhat, but I don't expect a big win. On the other hand I just told you how unreliable my expectations are, so there might be treasure after all. :)

René
Previous: Jeff KingNext: Jeff King
Message 6 of 18 in “strbuf: add and use strbuf_add_uint()”
  1. 0/4 strbuf: add and use strbuf_add_uint()René Scharfe, May 12, 2026
  2. 2/4 cat-file: use strbuf_add_uint()René Scharfe, May 12, 2026
  3. Jeff KingMay 12, 2026
  4. 1/4 strbuf: add strbuf_add_uint()René Scharfe, May 12, 2026
  5. Jeff KingMay 12, 2026
  6. René ScharfeMay 12, 2026
  7. Jeff KingMay 13, 2026
  8. Jeff KingMay 13, 2026
  9. Jeff KingMay 13, 2026
  10. René ScharfeMay 14, 2026
  11. Junio C HamanoMay 14, 2026
  12. Jeff KingMay 15, 2026
  13. René ScharfeMay 13, 2026
  14. 4/4 ls-tree: use strbuf_add_uint()René Scharfe, May 12, 2026
  15. 3/4 ls-files: use strbuf_add_uint()René Scharfe, May 12, 2026
  16. Jeff KingMay 12, 2026
  17. René ScharfeMay 12, 2026
  18. Jeff KingMay 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.