RE: Formatting options are ignored when tracking functions

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 23, 2021, 02:28 UTC
Message-ID: <60a9bdbf37fb7_87b7e208f0@natae.notmuch>
In-Reply-To: <63cf407c-95bd-fdda-88ec-5eca36d24998@gmail.com>

Aidan wrote:

Show 20 quoted lines

> Does not work tracking a function
> ---------------------------
> aidan@AidanLaptop:~/Repos/git$ git log -L:vadvise:advice.c --oneline
> b3b18d1621 advice: revamp advise API
> diff --git a/advice.c b/advice.c
> --- a/advice.c
> +++ b/advice.c
> @@ -99,19 +141,23 @@
> -static void vadvise(const char *advice, va_list params)
> +static void vadvise(const char *advice, int display_instructions,
> +                   const char *key, va_list params)
>   {
>          struct strbuf buf = STRBUF_INIT;
>          const char *cp, *np;
> 
>          strbuf_vaddf(&buf, advice, params);
> 
> ---------------------------
> 
> Is this a bug or am I invoking the command incorrectly?

According to the documentation -L implies --patch, so you need to do:

  git log -L:vadvise:advice.c --oneline --no-patch

I would not expect such behavior so to me that's a bug.

-- 
Felipe Contreras