Re: [PATCH v2 01/11] doc: doc-diff: set docdate manually

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 22, 2021, 21:27 UTC
Message-ID: <60a9775a494b5_857e9208ca@natae.notmuch>
In-Reply-To: <0c4ca3b5-7be4-1cdc-fbf1-b7a1541fe4b2@gmail.com>

Bagas Sanjaya wrote:

Show 8 quoted lines

> On 22/05/21 05.44, Felipe Contreras wrote:
> > In order to minimize the differences in the footer.
> > 
> > Asciidoc automatically generates a date with format '%Y-%m-%d', while
> > asciidoctor '%F'.
> > 
> 
> %F is short yyyy-mm-dd date. AFAIK, it is the same effect as `%Y-%m-%d`.

Right, I noticed I was wrong when trying to use -adocdate in asciidoctor. It's actually ignored.

The date format probably comes from docbook. The commit message needs to be updated.

Show 10 quoted lines

> > I personally prefer the latter, so only modify it for diff purposes.
> > 
> > Fixes tons of these:
> > 
> > -Git omitted                       01/01/1970                        GIT-ADD(1)
> > +Git omitted                       1970-01-01                        GIT-ADD(1)
> >
>   
> So, the asciidoctor generated date was the bottom one, while the asciidoc
> counterpart was the above one, right?

Yeap.

> The above one, however, was actually %m/%d/%Y.

Indeed, the commit message is inaccurate.

-- 
Felipe Contreras