Re: [PATCH v5] help: colorize man pages

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 22, 2021, 21:15 UTC
Message-ID: <60a9747fc56de_857e9208b6@natae.notmuch>
In-Reply-To: <YKjVZ28fxqGq7Baq@coredump.intra.peff.net>

Jeff King wrote:

Show 17 quoted lines

> On Fri, May 21, 2021 at 08:17:18PM -0500, Felipe Contreras wrote:
> 
> > +	/* Add red to bold, blue to underline, and magenta to standout */
> > +	/* No visual information is lost */
> > +	setenv("LESS", "Dd+r$Du+b$Ds+m", 0);
> 
> Unlike the LESS_TERMCAP_* strategy, this completely breaks "git help"
> on my system:
> 
>   $ ./git help git
>   There is no -D option ("less --help" for help)
> 
>   $ man less | grep -A1 '^ *-D'
>          -Dxcolor or --color=xcolor
>                 [MS-DOS only] Sets the color of the text displayed.  x is a single
> 
> This is less 551-2 on Debian unstable.

I see.

Looking at their history it seems they only enabled this for non-MS-DOS builds in 2021.

That explains why most people haven't found this yet, and are using LESS_TERMCAP_*.

I'll revert back to LESS_TERMCAP_ and test with an ancient version of less.

Thanks for testing.

-- 
Felipe Contreras