Re: [PATCH v2 2/3] advice: fix an unexpected leading space

From: Rubén Justo <rjusto@gmail.com>
Date: Jan 12, 2024, 09:10 UTC
Message-ID: <60a90f4e-b22c-46cb-a79f-a0e01e711732@gmail.com>
In-Reply-To: <xmqqa5pbcpnx.fsf@gitster.g>

On 11-ene-2024 17:21:22, Junio C Hamano wrote:

Show 20 quoted lines

> Rubén Justo <rjusto@gmail.com> writes:
> 
> > [ ... ]
> > diff --git a/advice.h b/advice.h
> > index 0f584163f5..2affbe1426 100644
> > --- a/advice.h
> > +++ b/advice.h
> > @@ -49,6 +49,7 @@ struct string_list;
> >         ADVICE_UPDATE_SPARSE_PATH,
> >         ADVICE_WAITING_FOR_EDITOR,
> >         ADVICE_SKIPPED_CHERRY_PICKS,
> > +       ADVICE_WORKTREE_ADD_ORPHAN,
> >  };
> >
> > Note the hunk header, instead of a much more expected:
> >
> > @@ -49,6 +49,7 @@ enum advice_type
> 
> Next time, don't include "diff" output in the proposed log message
> without indenting.  It makes it hard to read and parse.

My fault.  Sorry.

Is there any way to make git-format-patch issue a warning or refuse to continue when the resulting patch is not going to be accepted by git-am?

> 
> The attached is what I queued in my tree.

Thanks.