Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads

From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Jun 21, 2013, 18:15 UTC
Message-ID: <603055CE-E8DE-4C53-9A7B-AE49CE515CCA@gernhardtsoftware.com>
In-Reply-To: <20130621181250.GA5290@sigill.intra.peff.net>

On Jun 21, 2013, at 2:12 PM, Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

> On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote:
> 
>> On Jun 21, 2013, at 2:03 PM, Jeff King <peff@peff.net> wrote:
>> 
>>> IfVersion comes from mod_version. I assume that if it were not
>>> loaded, apache would complain about the directive entirely. But it's
>>> true that we don't load it until later. Maybe try moving the
>>> IfVersion/Lockfile stanza down below the mod_version LoadModule
>>> line?
>> 
>> Apache is apparently overly accepting.  Moving the IfVersion below all
>> the IfModules fixes it.
> 
> Cool. I think the patch should look like the one below, then.

Basically identical to what I've done, you're just faster to the actual patch.  :-D

+1

Show 15 quoted lines

> Just to double-check that I have explained the issue correctly, can you
> share the output of "apache2 -l"? Mine has:
> 
>  $ apache2 -l
>  Compiled in modules:
>    core.c
>    mod_log_config.c
>    mod_logio.c
>    mod_version.c
>    prefork.c
>    http_core.c
>    mod_so.c
> 
> which explains why it works here. I'm assuming you will not have
> mod_version.c compiled in.

Indeed I do not.

 $ httpd -l
 Compiled in modules:
   core.c
   prefork.c
   http_core.c
   mod_so.c