Reference has invalid format: check maybe a bit to harsh?
- From
Peter Oberndorfer <kumbayo84@arcor.de>
- Date
- Oct 31, 2011, 19:14 UTC
- Message-ID
- <60007404.ge1WXNp2Qn@soybean>
Hi,
i am using the next branch for testing and i noticed the following: about any git command i execute in a certain repo dies with fatal: Reference has invalid format: 'refs/patches/obd_development/blah:_various_improvements_remote_debugging'
This is probably caused by dce4bab6567de7c458b334e029e3dedcab5f2648 add_ref(): verify that the refname is formatted correctly
The invalid refs(about 30, loose and packed) containing a ':' were created by stgit a long time ago(Dec 2006)
Personally i do not care too much, i patched my git to not die at this point but to only display a error. -> The invalid refs are not accessible, but the rest of the repo still works.
But i'm just wondering if dieing when seeing a single invalid ref might be a bit too harsh since no git tools can be used anymore on this repo at all.
Small side note: It seems t1402-check-ref-format.sh contains not test for the invalid ref char ':' yet. (i do not know if it is tested somewhere else...)
Thanks, Greetings Peter