Re: [PATCH 1/2] bundle-uri: ignore bundles without uri

From: Justin Tobler <jltobler@gmail.com>
Date: Sep 12, 2025, 17:11 UTC
Message-ID: <5hm6qdyn5ifs2kr33nwuc67qa3vdgis6w26rlvicrdzznzazzt@uytayxq5r25n>
In-Reply-To: <20250912-b4-toon-bundle-uri-no-uri-v1-1-f4525a406df8@iotcl.com>

On 25/09/12 06:46PM, Toon Claes wrote:

Show 8 quoted lines

> Bundle-URI can use the heuristic 'creationToken'. With this heuristic
> each bundle should specify a 'creationToken' next to the 'uri'
> attribute. But this allows misconfiguration where only a 'creationToken'
> and no 'uri' is specified for a bundle . Because Git expects each bundle
> to have a 'uri', this causes a segmentation fault.
> 
> Harden Git against bundles with missing 'uri' and skip bundles which
> miss this attribute.

Ultimately, the remote Git server is the source of truth and bundle-uri serves as a supplementary mechanism to retrieve objects. In cases where there are errors related to retrieving objects from the specified bundle-uri, it certainly makes sense for Git to warn/ignore these issues and continue on as if there was no bundle-uri.

I'm not sure though if this should extend to client-side misconfiguration. We don't want to segfault, but maybe we should return an error indicating the misconfiguration instead of just papering over it? At the very least, it would probably make sense to provide some sort of warning that the bundle-uri was misconfigured and not used.

-Justin