coccinelle: fine-tuning for commit.cocci?
- From
- Markus Elfring <markus.elfring@web.de>
- Date
- Nov 12, 2019, 17:50 UTC
- Message-ID
- <5ff15b03-aa04-f8f7-2989-cc5463e71d27@web.de>
Hello,
I would like to comment implementation details from the commit 301b8c7f405d3cd4f32b14bd336ac8c0400d9382 ("commit.c: add repo_get_commit_tree()").
1. Would you like to use a code variant (for the semantic patch language) which can work without a regular expression for the exclusion of a single item?
identifier f != set_commit_tree;
2. How do you think about the following variants for the specification of SmPL constraints?
* Advanced regular expression
identifier f !~ "^(?:get_commit_tree_in_graph_one|load_tree_for_commit|(?:repo_g|s)et_commit_tree)$";
* Item list filter
identifier f != { get_commit_tree_in_graph_one, load_tree_for_commit, repo_get_commit_tree, set_commit_tree };Regards, Markus