Re: [PATCH] doc: fix some typos

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 2, 2021, 22:26 UTC
Message-ID: <5ff0f31315732_a76d20833@natae.notmuch>
In-Reply-To: <CAN0heSojPyr=g5PBVmT4VTfxxKxzYcFXJ1jynM1tGuZSyQMykg@mail.gmail.com>

Martin Ågren wrote:

Show 28 quoted lines

> On Sat, 2 Jan 2021 at 18:43, Thomas Ackermann via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> 
> [Snip several typo fixes in Documentation/, all of which I agree with.]
> 
> > diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
> > index c151dd7257f..8f77baa678f 100644
> > --- a/contrib/buildsystems/CMakeLists.txt
> > +++ b/contrib/buildsystems/CMakeLists.txt
> 
> Hmm... This does not match the "doc:" prefix of the patch.
> 
> > @@ -442,7 +442,7 @@ endif()
> >  check_c_source_compiles("
> >  #include <regex.h>
> >  #ifndef REG_STARTEND
> > -#error oops we dont have it
> > +#error oops we don't have it
> >  #endif
> 
> I don't think this is correct. This omission of the single quote somehow
> looks like it's done on purpose. I don't build using this system, but I
> tried making some silly code like this in another file, which I actually
> do use:
> 
> #if 0
> #error might or mightn't work
> #endif

But this works:

#error "might or mightn't work"

-- 
Felipe Contreras