RE: [ANNOUNCE] Git v2.30.0-rc2
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Dec 24, 2020, 15:16 UTC
- Message-ID
- <5fe4b0e45fb85_19c9208c8@natae.notmuch>
- In-Reply-To
- <00ed01d6da03$f8928fc0$e9b7af40$@nexbridge.com>
Randall S. Becker wrote:
Show 28 quoted lines
> On December 24, 2020 1:36 AM, Junio C Hamano wrote: > > Junio C Hamano <gitster@pobox.com> writes: > > > > > Christian Couder <christian.couder@gmail.com> writes: > > > > > >> Most of the suggestions below are found by GMail. > > >> > > >> On Thu, Dec 24, 2020 at 12:08 AM Junio C Hamano <gitster@pobox.com> > > wrote: > > >>> > > >>> A release candidate Git v2.30.0-rc2 is now available for testing at > > >>> the usual places. It is comprised of 19 non-merge commits since > > >> > > >> Maybe: s/is comprised of/comprises/ > > > > > > Funny. > > > > > > I do recall somebody else (perhaps Peff but I may be misremembering) > > > helped me grammofixing the use of verb "comprise" in the sentence when > > > I started listing the names of commit authors back in v2.3.3 or > > > v2.4.0 era. Perhaps I failed to follow the advice given? I dunno. > > NonStop test cycle in progress on both platforms. > > And "comprises" is considered correct as the present tense according to > Merriam-Webster. "Is comprised of" is more formal and tends to get edited > down to "comprises" by current grammar checkers to reduce use of the passive > form of verbs that pervades technical documents and thesis papers.
Techically it's wrong [1]:
"The whole comprises the parts; thus is comprised of is wrong."
But many people use it, so it's not *that* wrong.
[1] https://www.merriam-webster.com/words-at-play/can-you-use-comprised-of-grammar
-- Felipe Contreras