RE: What's cooking in git.git (Dec 2020, #03; Fri, 18)
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Dec 19, 2020, 14:10 UTC
- Message-ID
- <5fde09c1ac7d_1def912083c@natae.notmuch>
- In-Reply-To
- <xmqq7dpeqrz4.fsf@gitster.c.googlers.com>
Junio C Hamano wrote:
Show 29 quoted lines
> * fc/bash-completion-post-2.29 (2020-11-10) 26 commits > - completion: bash: shuffle __gitcomp functions > - completion: bash: cleanup __gitcomp* invocations > - completion: bash: add __gitcomp_opts > - completion: bash: improve __gitcomp description > - completion: bash: rename _get_comp_words_by_ref() > - completion: bash: trivial cleanup > - completion: bash: cleanup _get_comp_words_by_ref() > - completion: bash: refactor _get_comp_words_by_ref() > - completion: bash: simplify _get_comp_words_by_ref() > - test: completion: switch __gitcomp_nl prefix test > - completion: bash: simplify config_variable_name > - completion: bash: improve __gitcomp suffix code > - completion: bash: change suffix check in __gitcomp > - completion: bash: simplify __gitcomp > - completion: bash: refactor __gitcomp > - completion: bash: simplify equal suffix check > - completion: bash: factor out check in __gitcomp > - completion: bash: get rid of any non-append code > - completion: bash: get rid of _append() functions > - completion: bash: remove non-append functionality > - test: completion: add run_func() helper > - test: completion: fix currently typed words > - completion: bash: do not modify COMP_WORDBREAKS > - completion: bash: fix for suboptions with value > - completion: bash: add correct suffix in variables > - completion: bash: fix prefix detection in branch.* > > Needs review.
I think I already mentioned these should be dropped in favor of an easier to digest series [1].
I just sent another try as a reminder [2].
Cheers.
[1] https://lore.kernel.org/git/20201119015209.1155170-1-felipe.contreras@gmail.com/ [2] https://lore.kernel.org/git/20201219140621.1961760-1-felipe.contreras@gmail.com/
-- Felipe Contreras