Re: MinGW port pull request
- From
Jim Raden <james.raden@gmail.com>
- Date
- Jun 21, 2008, 21:21 UTC
- Message-ID
- <5fc54b450806211421m64eee6e5l3622243e65f633a2@mail.gmail.com>
- In-Reply-To
- <200806212318.47745.johannes.sixt@telecom.at>
On Sat, Jun 21, 2008 at 5:18 PM, Johannes Sixt <johannes.sixt@telecom.at> wrote:
Show 18 quoted lines
> > > * There are still too many ifdefs. I am wondering if the changes to > > pager and process stuff is easier to manage in the longer term if they > > are made into completely separate files (i.e. instead of linking > > pager.o you would link mingw-pager.o). I dunno. > > I think that would not be helpful. Both parts need to be maintained, > whether > they are in the same file or in different files. If they are in one file, > and > someone needs to make a change, then there is a chance that a corresponding > change is made in the MINGW32 arm. If not then there is another chance that > the person would at least say "I don't know how to do it for MINGW32". But > if > you separate the implementations completely, then both chances are missed > much easier. > > I quite agree!!