[PATCH v5 3/7] git-p4: add p4-pre-submit exit text
- From
Ben Keene via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Feb 11, 2020, 18:58 UTC
- Message-ID
- <5f2b47bf6aa2686d2c8d9a47f73daed59cd94af5.1581447485.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.698.v5.git.git.1581447484.gitgitgadget@gmail.com>
From: Ben Keene <seraphire@gmail.com>
When the p4-pre-submit exits with a non-zero exit code, the application will abort the process with no additional information presented to the user. This can be confusing for new users as it may not be clear that the p4-pre-submit action caused the error.
Add text to explain why the program aborted the submit action.
Signed-off-by: Ben Keene <seraphire@gmail.com> --- git-p4.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/git-p4.py b/git-p4.py index 4eccea3fa5..b1c86678fc 100755 --- a/git-p4.py +++ b/git-p4.py @@ -2405,7 +2405,15 @@ def run(self, args): sys.exit("number of commits (%d) must match number of shelved changelist (%d)" % (len(commits), num_shelves)) - if not run_git_hook("p4-pre-submit"): + try: + if not run_git_hook("p4-pre-submit"): + print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nYou can skip " \ + "this pre-submission check by adding\nthe command line option '--no-verify', " \ + "however,\nthis will also skip the p4-changelist hook as well.") + sys.exit(1) + except Exception as e: + print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nThe hook failed "\ + "with the error '{0}'".format(e.message) ) sys.exit(1) #
-- gitgitgadget